Ard,
I will address your suggestions in v4. And below is my comments for a
few of them.
On Mon, Nov 05, 2018 at 02:22:21PM +0100, Ard Biesheuvel wrote:
> > +static const struct streebog_uint512 buffer512 = { {
> > + cpu_to_le64(0x200ULL),
>
> Can we keep the memory representation in native endianness, and only
> swab the in/output [where needed]?
Yes. This will slightly affect performance on big-endian architectures,
but, probably this is not a concern.
> Also, did you test this code on a big-endian system?
Yes, on s390x on qemu.
> > + .cra_name = "sb256",
>
> Please use the full name 'streebog256' (and 512 below)
First, I thought of shortening name like Whirlpool do with wp256, but
now I rethought this and agree.
Thanks!
