Hi Leonard,
On Wed, Oct 17, 2018 at 9:38 AM Leonard Crestez <leonard.crestez@xxxxxxx> wrote:
>
> On 6ull and 6sll the DCP block has a clock which needs to be explicitly
> enabled.
>
> Add minimal handling for this at probe/remove time.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@xxxxxxx>
> ---
Please always explain what changed from the previous patch version.
> + /* Restart the DCP block. */
> + ret = stmp_reset_block(sdcp->base);
> + if (ret) {
> + dev_err(dev, "Failed reset\n");
> + goto err_disable_unprepare_clk;
> + }
This seems like an unrelated change that should be in a separate patch.
Also, this was not present in v3, so it is better to explain that this
has been introduced in v4.
