On Tue, Oct 16, 2018 at 09:44:02PM +0200, Gustavo A. R. Silva wrote: > Hi all, > > On 10/9/18 12:20 AM, Kees Cook wrote: > > On Mon, Oct 8, 2018 at 12:17 PM, Gustavo A. R. Silva > > <gustavo@xxxxxxxxxxxxxx> wrote: > >> The original intention is to allocate space for EIP197_DEFAULT_RING_SIZE > >> *pointers* to struct, so sizeof(priv->ring[i].rdr_req) should be > >> sizeof(*priv->ring[i].rdr_req). > >> > >> Addresses-Coverity-ID: 1473962 ("Sizeof not portable") > >> Fixes: 9744fec95f06 ("crypto: inside-secure - remove request list to improve performance") > >> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> > > > > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> > > > > > Friendly ping. Who can take this? Well I tried to take it but it doesn't apply against cryptodev. So I presume this can go into the tree that carried the change which it depended on? Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt