On 13-10-2018 05:46, Lino Sanfilippo wrote: > Hi, > >> + if (uld_type == CXGB4_ULD_CRYPTO) { >> + i = min_t(int, adap->vres.ncrypto_fc, >> + num_online_cpus()); >> + txq_info->ntxq = rounddown(i, adap->params.nports); >> + if (txq_info->ntxq <= 0) { >> + dev_warn(adap->pdev_dev, "Crypto Tx Queues can't be zero\n"); >> + return -EINVAL; >> + } > Shouldn't we free txq_info in the error case? Yes, Will fix this in V2. Thanks. > > Regards, > Lino