Hi Ard, On Fri, Sep 28, 2018 at 5:47 PM Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote: > Please drop this SOB line: SOB is not about (co-)authorship but about > who handled the patch on its way into mainline. The s-o-b line is about the DCoO, which is given here by both of us, with the code starting in a shared tree that only had that s-o-b. I can remove it though if you think it's strange to have two s-o-bs. > You are sending the > patch so your SOB should come last. I was wondering about the ordering of these, actually. I've seen s-o-b on top and s-o-b on bottom of the cc list in lots of commits and haven't yet divined the One True Position. > You can drop the #ifdefs above ... Yep. All of those ifdefs in this and in the other primitives are already gone, and everything is fully IS_ENABLEDenabled now. > > +#ifdef CONFIG_AS_AVX512 > > ... and use IS_ENABLED(CONFIG_AS_AVX512) here inside the if(). Already done, per your suggestion a few days ago. > > -#ifndef HAVE_CHACHA20_ARCH_IMPLEMENTATION > > As I mentioned in reply to the previous patch, please get rid of this > CPP symbol ^^^ Ack. Jason
