On Tue, Sep 25, 2018 at 10:00 PM Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote: > > On Sep 25, 2018, at 12:43 PM, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: > > > >> On Tue, Sep 25, 2018 at 8:33 PM Joe Perches <joe@xxxxxxxxxxx> wrote: > >> I think the -Dpr_fmt is especially odd and not > >> really acceptable as it not used anywhere else > >> in the kernel. > > > > There are about 2000 cases in the kernel of the same '#define > > pr_fmt...' being pasted into the top of the file, which seems a bit > > cumbersome. Rather than having to paste that into each and every file > > that I pr_err from, why can't I just do this from the makefile, since > > I want that same pr_fmt to copy the whole directory? > > Because people like to be able to just read the C file to figure out what it does. Or we could adopt the Makefile approach kernel-wide, since this use of it seems reasonable. It would indeed be nice to see this done tree-wide. I can recall various random bugs over the year where some dmesg messages are missing a prefix because the author forgot to copy and paste the thing to /yet another file/ in the same directory.
