On Mon, Sep 24, 2018 at 9:49 PM, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Sep 24, 2018 at 05:49:37PM -0700, Kees Cook wrote: >> >> > Kees Cook (23): >> > crypto: skcipher - Introduce crypto_sync_skcipher >> > gss_krb5: Remove VLA usage of skcipher >> > lib80211: Remove VLA usage of skcipher >> > mac802154: Remove VLA usage of skcipher >> > s390/crypto: Remove VLA usage of skcipher >> > x86/fpu: Remove VLA usage of skcipher >> > block: cryptoloop: Remove VLA usage of skcipher >> > libceph: Remove VLA usage of skcipher >> > ppp: mppe: Remove VLA usage of skcipher >> > rxrpc: Remove VLA usage of skcipher >> > wusb: Remove VLA usage of skcipher >> > crypto: ccp - Remove VLA usage of skcipher >> > crypto: vmx - Remove VLA usage of skcipher >> > crypto: null - Remove VLA usage of skcipher >> > crypto: cryptd - Remove VLA usage of skcipher >> > crypto: sahara - Remove VLA usage of skcipher >> > crypto: qce - Remove VLA usage of skcipher >> > crypto: artpec6 - Remove VLA usage of skcipher >> > crypto: chelsio - Remove VLA usage of skcipher >> > crypto: mxs-dcp - Remove VLA usage of skcipher >> > crypto: omap-aes - Remove VLA usage of skcipher >> > crypto: picoxcell - Remove VLA usage of skcipher >> > crypto: skcipher - Remove SKCIPHER_REQUEST_ON_STACK() >> >> How do these look to you, Herbert? I'd really like to make sure these >> make it for the next merge window -- they're the last VLAs left in the >> kernel now. :) > > I have no problems with the crypto parts. Do we have acks for > all of the others? Some have trickled in (wusb, lib80211), along with some Reviewed-bys from Ard. I was hoping that since it was a wrapper-only change there wouldn't be a need to block on waiting for Acks. Thanks for looking at it; I'm excited to finally be done with VLA removals. :) -Kees -- Kees Cook Pixel Security
