Hi Jason, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jason-A-Donenfeld/WireGuard-Secure-Network-Tunnel/20180916-043623 config: x86_64-randconfig-b0-09160521 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): In file included from lib/zinc/curve25519/curve25519.c:45:0: lib/zinc/curve25519/curve25519-hacl64.h: In function 'curve25519_generic': >> lib/zinc/curve25519/curve25519-hacl64.h:785:1: warning: the frame size of 13216 bytes is larger than 8192 bytes [-Wframe-larger-than=] } ^ vim +785 lib/zinc/curve25519/curve25519-hacl64.h cec5aa7c Jason A. Donenfeld 2018-09-14 755 cec5aa7c Jason A. Donenfeld 2018-09-14 756 static void curve25519_generic(u8 mypublic[CURVE25519_POINT_SIZE], cec5aa7c Jason A. Donenfeld 2018-09-14 757 const u8 secret[CURVE25519_POINT_SIZE], cec5aa7c Jason A. Donenfeld 2018-09-14 758 const u8 basepoint[CURVE25519_POINT_SIZE]) cec5aa7c Jason A. Donenfeld 2018-09-14 759 { cec5aa7c Jason A. Donenfeld 2018-09-14 760 u64 buf0[10] __aligned(32) = { 0 }; cec5aa7c Jason A. Donenfeld 2018-09-14 761 u64 *x0 = buf0; cec5aa7c Jason A. Donenfeld 2018-09-14 762 u64 *z = buf0 + 5; cec5aa7c Jason A. Donenfeld 2018-09-14 763 u64 *q; cec5aa7c Jason A. Donenfeld 2018-09-14 764 format_fexpand(x0, basepoint); cec5aa7c Jason A. Donenfeld 2018-09-14 765 z[0] = 1; cec5aa7c Jason A. Donenfeld 2018-09-14 766 q = buf0; cec5aa7c Jason A. Donenfeld 2018-09-14 767 { cec5aa7c Jason A. Donenfeld 2018-09-14 768 u8 e[32] __aligned(32) = { 0 }; cec5aa7c Jason A. Donenfeld 2018-09-14 769 u8 *scalar; cec5aa7c Jason A. Donenfeld 2018-09-14 770 memcpy(e, secret, 32); cec5aa7c Jason A. Donenfeld 2018-09-14 771 normalize_secret(e); cec5aa7c Jason A. Donenfeld 2018-09-14 772 scalar = e; cec5aa7c Jason A. Donenfeld 2018-09-14 773 { cec5aa7c Jason A. Donenfeld 2018-09-14 774 u64 buf[15] = { 0 }; cec5aa7c Jason A. Donenfeld 2018-09-14 775 u64 *nq = buf; cec5aa7c Jason A. Donenfeld 2018-09-14 776 u64 *x = nq; cec5aa7c Jason A. Donenfeld 2018-09-14 777 x[0] = 1; cec5aa7c Jason A. Donenfeld 2018-09-14 778 ladder_cmult(nq, scalar, q); cec5aa7c Jason A. Donenfeld 2018-09-14 779 format_scalar_of_point(mypublic, nq); cec5aa7c Jason A. Donenfeld 2018-09-14 780 memzero_explicit(buf, sizeof(buf)); cec5aa7c Jason A. Donenfeld 2018-09-14 781 } cec5aa7c Jason A. Donenfeld 2018-09-14 782 memzero_explicit(e, sizeof(e)); cec5aa7c Jason A. Donenfeld 2018-09-14 783 } cec5aa7c Jason A. Donenfeld 2018-09-14 784 memzero_explicit(buf0, sizeof(buf0)); cec5aa7c Jason A. Donenfeld 2018-09-14 @785 } :::::: The code at line 785 was first introduced by commit :::::: cec5aa7cd396d909f8555d2df80d3e1a0f94688b zinc: Curve25519 generic C implementations and selftest :::::: TO: Jason A. Donenfeld <Jason@xxxxxxxxx> :::::: CC: 0day robot <lkp@xxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
