On Tue, Aug 21, 2018 at 02:43:56PM +0200, Ard Biesheuvel wrote: > > I agree. The code is obviously broken in a way that would have been > noticed if it were in wide use, and it is too complicated for mere > mortals to fix or maintain. I suggest we simply remove it for now, and > if anyone wants to reintroduce it, we can review the code *and* the > justification for the approach from scratch (in which case we should > consider factoring out the algo agnostics plumbing in a way that > allows it to be reused by other architectures as well) I agree too. Could one of you guys send me a patch to remove them? Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt