Re: [PATCH v6 16/18] rxrpc: Reuse SKCIPHER_REQUEST_ON_STACK buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v6 16/18] rxrpc: Reuse SKCIPHER_REQUEST_ON_STACK buffer
From: David Howells <dhowells@xxxxxxxxxx>
Date: Fri, 03 Aug 2018 10:14:28 +0100
Cc: dhowells@xxxxxxxxxx, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Eric Biggers <ebiggers@xxxxxxxxxx>, "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx>, linux-crypto <linux-crypto@xxxxxxxxxxxxxxx>, Network Development <netdev@xxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <CAGXu5jLVNnUXkyzGdee3zvLHw5zMaDhEGm4c4YLqU=L8q9TshA@mail.gmail.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
References: <CAGXu5jLVNnUXkyzGdee3zvLHw5zMaDhEGm4c4YLqU=L8q9TshA@mail.gmail.com> <20180724164936.37477-1-keescook@chromium.org> <20180724164936.37477-17-keescook@chromium.org>

Hmmm...  I'm wondering if the skcipher request should be allocated on call
initialisation and a pointer put in the rxrpc_call struct.  It's only used
serially for any particular call.

For the moment, I'll pass your patch onto DaveM.

David

References:
- Re: [PATCH v6 16/18] rxrpc: Reuse SKCIPHER_REQUEST_ON_STACK buffer
  - From: Kees Cook
- [PATCH v6 00/18] crypto: Remove VLA usage
  - From: Kees Cook
- [PATCH v6 16/18] rxrpc: Reuse SKCIPHER_REQUEST_ON_STACK buffer
  - From: Kees Cook

Prev by Date: Re: [PATCH] crypto: arm64 - revert NEON yield for fast AEAD implementations
Next by Date: Re: [PATCH] crypto: x86/aegis - Fix CPUID checks
Previous by thread: Re: [PATCH v6 16/18] rxrpc: Reuse SKCIPHER_REQUEST_ON_STACK buffer
Next by thread: [PATCH v6 18/18] crypto: Remove AHASH_REQUEST_ON_STACK
Index(es):
- Date
- Thread

[Index of Archives] [Kernel] [Gnu Classpath] [Gnu Crypto] [DM Crypt] [Netfilter] [Bugtraq]