RE: [PATCH 1/4] crypto/arm64: ghash - reduce performance impact of NEON yield checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: bigeasy@xxxxxxxxxxxxx [mailto:bigeasy@xxxxxxxxxxxxx]
> Sent: Wednesday, July 25, 2018 12:33 PM
> To: Vakul Garg <vakul.garg@xxxxxxx>
> Cc: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>; linux-
> crypto@xxxxxxxxxxxxxxx; herbert@xxxxxxxxxxxxxxxxxxx;
> will.deacon@xxxxxxx; dave.martin@xxxxxxx
> Subject: Re: [PATCH 1/4] crypto/arm64: ghash - reduce performance impact
> of NEON yield checks
> 
> On 2018-07-25 06:57:42 [+0000], Vakul Garg wrote:
> > I tested this patch. It helped but didn't regain the performance to previous
> level.
> > Are there more files remaining to be fixed? (In your original patch
> > series for adding preemptability check, there were lot more files changed
> than this series with 4 files).
> >
> > Instead of using hardcoded  32 block/16 block limit, should it be controlled
> using Kconfig?
> > I believe that on different cores, these values could be required to be
> different.
> 
> What about PREEMPT_NONE (server)?

Why not have best of both the worlds :)

> 
> Sebastian




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux