On Sat, Jul 14, 2018 at 7:44 PM, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > On Fri, Jul 13, 2018 at 08:07:10PM -0700, Kees Cook wrote: >> >> On a plane today I started converting all these to shash. IIUC, it >> just looks like this (apologies for whitespace damage): > > Yes if it doesn't actually make use of SGs then shash would be > the way to go. However, for SG users ahash is the best interface. Nearly all of them artificially build an sg explicitly to use the ahash interface. :P So, I'll take that as a "yes, do these conversions." :) Thanks! -Kees -- Kees Cook Pixel Security