[bug report] crypto: ccp - Add DOWNLOAD_FIRMWARE SEV command

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

Hello Janakarajan Natarajan,

The patch edd303ff0e9e: "crypto: ccp - Add DOWNLOAD_FIRMWARE SEV
command" from May 25, 2018, leads to the following static checker
warning:

	drivers/crypto/ccp/psp-dev.c:397 sev_get_api_version()
	error: uninitialized symbol 'error'.

drivers/crypto/ccp/psp-dev.c
   389  static int sev_get_api_version(void)
   390  {
   391          struct sev_user_data_status *status;
   392          int error, ret;
   393  
   394          status = &psp_master->status_cmd_buf;
   395          ret = sev_platform_status(status, &error);
   396          if (ret) {
   397                  dev_err(psp_master->dev,
   398                          "SEV: failed to get status. Error: %#x\n", error);

sev_platform_status() could be defined as a no-op or there is an error
path where *error isn't set.

   399                  return 1;
   400          }
   401  
   402          psp_master->api_major = status->api_major;
   403          psp_master->api_minor = status->api_minor;
   404          psp_master->build = status->build;
   405  
   406          return 0;
   407  }

regards,
dan carpenter