On Sat, Jun 30, 2018 at 03:16:10PM -0700, Eric Biggers wrote: > Originally, algorithms had to declare their type in .cra_flags as a > CRYPTO_ALG_TYPE_* value. Some types of algorithms such as "cipher" > still have to do this. But now most algorithm types use different > top-level C data structures, and different registration and allocation > functions. And for these, the core crypto API automatically sets the > .cra_flags type as well as .cra_type, mainly for its own use (users > shouldn't care about these). > > Yet, many algorithms are still explicitly setting their .cra_flags type > and sometimes even .cra_type, which is confusing as this actually does > nothing. Apparently, people are just copy-and-pasting this from > existing code without understanding it. > > Therefore, this patchset removes the useless initializations, as well as > useless type flags passed to the strongly-typed tfm allocators. > > This doesn't change any actual behavior, AFAIK. > > For now I didn't bother with 'blkcipher' and 'ablkcipher' algorithms, > since those should eventually be migrated to 'skcipher' anyway. > > Eric Biggers (6): > crypto: shash - remove useless setting of type flags > crypto: ahash - remove useless setting of type flags > crypto: ahash - remove useless setting of cra_type > crypto: aead - remove useless setting of type flags > crypto: skcipher - remove useless setting of type flags > crypto: remove redundant type flags from tfm allocation All applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
