On Tue, Jul 3, 2018 at 6:31 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote: > Hi Logan, > > On Fri, Jun 22, 2018 at 4:47 PM, Logan Gunthorpe <logang@xxxxxxxxxxxx> wrote: >> Clean up the extra ifdefs which defined the wr_reg64 and rd_reg64 >> functions in non-64bit cases in favour of the new common >> io-64-nonatomic-lo-hi header. >> >> To be consistent with CAAM engine HW spec: in case of 64-bit registers, >> irrespective of device endianness, the lower address should be read from >> / written to first, followed by the upper address. Indeed the I/O >> accessors in CAAM driver currently don't follow the spec, however this >> is a good opportunity to fix the code. >> >> Signed-off-by: Logan Gunthorpe <logang@xxxxxxxxxxxx> >> Reviewed-by: Horia Geantă <horia.geanta@xxxxxxx> >> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> >> Cc: Dan Douglass <dan.douglass@xxxxxxx> >> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> >> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > > This is now in linux-next as commit 46e4bf08f6388 and it breaks > booting imx6 (32-bit ARM): > Any ideas on how to fix this issue? Oops, first of all the header should be hi-lo instead of lo-hi. Does it fix it? Otherwise I didn't (briefly) see what can be the issue. -- With Best Regards, Andy Shevchenko
