On Thu, Jun 21, 2018 at 07:12:47AM +0900, Juan Manuel Torres Palma wrote: > On Wed, Jun 20, 2018 at 11:10:51AM -0700, Eric Biggers wrote: > > Also, can you describe the users of Skein in the kernel? If there are no users, > > there's no need to move it out of staging, or even have it in the kernel at all > > anymore. I say that as someone who has had to volunteer to fix critical bugs > > found by fuzzing in crypto algorithms for which it's unclear why they are in the > > kernel at all, as there are no apparent users. > > To be honest I'm not aware of anyone actually using Skein. > > So by this are you suggesting that we drop support? If not removed, I believe > it's better to use test vectors as regression tests for further modifications. Let's just remove skein. In fact staging should never add generic crypto algorithms. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
