Hi Herbert, On 06/19/2018 05:28 PM, Herbert Xu wrote: > On Mon, Jun 18, 2018 at 07:42:59PM +0530, Vinod Koul wrote: >> Qcom 8996 and later chips support prng v2 where we need to only >> implement .read callback for hwrng. >> >> Add a new table for v2 which supports this and get version required for >> driver data. >> >> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> > > Is this really a pseudo-RNG? If so it needs to be moved over to > the algif_rng interface. Despite the register name (PRNG_ registers prefix) the IP is using FIPS approved algorithm and we can claim that this is true hardware entropy generator. I don't think that we need to move to algif_rng. -- regards, Stan