On 05/31/2018 08:52 PM, Stewart Smith wrote: > Haren Myneni <haren@xxxxxxxxxxxxxxxxxx> writes: >> NX increments readOffset by FIFO size in receive FIFO control register >> when CRB is read. But the index in RxFIFO has to match with the >> corresponding entry in FIFO maintained by VAS in kernel. Otherwise NX >> may be processing incorrect CRBs and can cause CRB timeout. >> >> VAS FIFO offset is 0 when the receive window is opened during >> initialization. When the module is reloaded or in kexec boot, readOffset >> in FIFO control register may not match with VAS entry. This patch adds >> nx_coproc_init OPAL call to reset readOffset and queued entries in FIFO >> control register for both high and normal FIFOs. >> >> Signed-off-by: Haren Myneni <haren@xxxxxxxxxx> > > I've yet to go and check out the skiboot patch properly, but should this > be both: > Fixes: b0d6c9bab crypto/nx: Add P9 NX support for 842 compression engine > CC: stable # v4.14+ > > as otherwise "rmmod ; insmod" will crash, and possibly even issues over kexec? > Correct, P9 NX support is included in 4.14. We also need fix in stable trees (4.14+). But this patch will not apply cleanly. I will post different patch for 4.14 and 4.16 stable trees. Thanks Haren
