On Sun, May 20, 2018 at 10:50:24PM -0700, Eric Biggers wrote: > Hello, > > When adding the Speck cipher support I was annoyed by having to add both > encryption and decryption test vectors, since they are redundant: the > decryption ones are just the encryption ones with the input and result > flipped. > > It turns out that's nearly always the case for all the other > ciphers/skciphers too. A few have slight differences, but they seem to > be accidental except for "kw(aes)", and we can still handle "kw(aes)" > nearly as easily with just one copy of the test vectors. > > Therefore, this series removes all the decryption cipher_testvecs and > updates testmgr to test both encryption and decryption using what used > to be the encryption test vectors. I did not change any of the AEAD > test vectors, though a similar change could be made for them too. > > Patches 1-4 add some encryption test vectors, just so no test coverage > is lost. Patch 5 is the real patch. Due to the 10000+ lines deleted > from testmgr.h, the patch file is 615 KB so it may be too large for the > mailing list. You can also grab the series from git: > https://github.com/ebiggers/linux, branch "test_vector_redundancy_v1" > (HEAD is a09e48518f957bb61bb278227917eaad64cf13be). Most of the patch > is scripted, but there are also some manual changes, mostly to > testmgr.c. For review purposes, in case the full 615 KB patch doesn't > reach the mailing list, I'm also pasting an abbreviated version of the > patch below that excludes the scripted changes to testmgr.h, i.e. it > only includes my manual changes on top of the scripted changes. > > Eric Biggers (5): > crypto: testmgr - add extra ecb(des) encryption test vectors > crypto: testmgr - make an cbc(des) encryption test vector chunked > crypto: testmgr - add extra ecb(tnepres) encryption test vectors > crypto: testmgr - add extra kw(aes) encryption test vector > crypto: testmgr - eliminate redundant decryption test vectors > > crypto/testmgr.c | 409 +- > crypto/testmgr.h | 12227 ++++----------------------------------------- > 2 files changed, 954 insertions(+), 11682 deletions(-) All applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
