Hello, The x86 asm implementations of Salsa20 have been missed so far in the fixes to stop abusing %ebp/%rbp in asm code to get correct stack traces. This has been causing the unwinder warnings reported by syzkaller to continue. This series "fixes" it by just removing the offending salsa20-asm implementations, which as far as I can tell are basically useless these days; the x86_64 asm version in particular isn't actually any faster than the C version anymore. (And possibly no one even uses these anyway.) See the patch for the full explanation. Eric Biggers (2): crypto: x86/salsa20 - remove x86 salsa20 implementations crypto: salsa20 - Revert "crypto: salsa20 - export generic helpers" arch/x86/crypto/Makefile | 4 - arch/x86/crypto/salsa20-i586-asm_32.S | 938 ------------------------ arch/x86/crypto/salsa20-x86_64-asm_64.S | 805 -------------------- arch/x86/crypto/salsa20_glue.c | 91 --- crypto/Kconfig | 28 - crypto/salsa20_generic.c | 20 +- include/crypto/salsa20.h | 27 - 7 files changed, 13 insertions(+), 1900 deletions(-) delete mode 100644 arch/x86/crypto/salsa20-i586-asm_32.S delete mode 100644 arch/x86/crypto/salsa20-x86_64-asm_64.S delete mode 100644 arch/x86/crypto/salsa20_glue.c delete mode 100644 include/crypto/salsa20.h -- 2.17.0
