On Wed, Apr 25, 2018 at 08:36:22PM +0530, Atul Gupta wrote:
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Atul Gupta <atul.gupta@xxxxxxxxxxx>
> ---
> drivers/crypto/chelsio/chtls/chtls_main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/chelsio/chtls/chtls_main.c b/drivers/crypto/chelsio/chtls/chtls_main.c
> index e9ffc3d..4dc3d0e 100644
> --- a/drivers/crypto/chelsio/chtls/chtls_main.c
> +++ b/drivers/crypto/chelsio/chtls/chtls_main.c
> @@ -198,7 +198,7 @@ static void *chtls_uld_add(const struct cxgb4_lld_info *info)
> {
> struct cxgb4_lld_info *lldi;
> struct chtls_dev *cdev;
> - int i, j;
> + int i;
>
> cdev = kzalloc(sizeof(*cdev) + info->nports *
> (sizeof(struct net_device *)), GFP_KERNEL);
> @@ -250,8 +250,8 @@ static void *chtls_uld_add(const struct cxgb4_lld_info *info)
>
> return cdev;
> out_rspq_skb:
> - for (j = 0; j <= i; j++)
> - kfree_skb(cdev->rspq_skb_cache[j]);
> + for (; i > 0; --i)
> + kfree_skb(cdev->rspq_skb_cache[i]);
It should be i >= 0 so that we free cdev->rspq_skb_cache[0].
regards,
dan carpenter
