Hi Arnd, On Tue, Apr 17, 2018 at 9:53 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Tue, Apr 17, 2018 at 8:14 PM, Geert Uytterhoeven > <geert@xxxxxxxxxxxxxx> wrote: >> The ARM TrustZone CryptoCell is found on ARM SoCs only. Hence make it >> depend on ARM or ARM64, unless compile-testing. >> >> Drop the dependency on HAS_DMA, as DMA is always available on ARM and >> ARM64 platforms, and doing so will increase compile coverage. >> >> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> >> --- >> Is ARM || ARM64 OK? >> Or should this be limited to either ARM or ARM64? Or something else? > > ARM || ARM64 seems fine, but don't you need '|| (HAS_DMA && COMPILE_TEST)'? > > I assume the HAS_DMA dependency was added to prevent compile > testing to run into a build error. Probably it was. But in v4.17-rc1, dummies are present in the NO_DMA case, so everything compile-tests fine. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds