018-04-08 5:19 GMT+02:00 Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>: > On Sat, Apr 07, 2018 at 08:38:19PM +0200, Salvatore Mesoraca wrote: >> >> @@ -206,6 +207,14 @@ static struct crypto_instance *crypto_ctr_alloc(struct rtattr **tb) >> if (alg->cra_blocksize < 4) >> goto out_put_alg; >> >> + /* Block size must be <= MAX_BLOCKSIZE. */ >> + if (alg->cra_blocksize > MAX_BLOCKSIZE) >> + goto out_put_alg; >> + >> + /* Alignmask must be <= MAX_ALIGNMASK. */ >> + if (alg->cra_alignmask > MAX_ALIGNMASK) >> + goto out_put_alg; >> + > > Since you're also adding a check to cipher algorithms in general, > none of these individual checks are needed anymore. Fair enough. After removing the individual checks the modification to the single files will be just a couple of lines, is it OK for you if I collapse all of them in just a single commit? Thank you, Salvatore
