Re: [PATCH v2 0/9] crypto: don't leak pointers to authenc keys

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 23, 2018 at 12:42:15PM +0200, Tudor Ambarus wrote:
> There are few places in crypto where we save pointers to the
> authenc keys to a local variable of type struct crypto_authenc_keys
> and we don't zeroize it after use. Fix all those cases and don't
> leak pointers to the authenc keys.
> 
> --
> 
> Changes in v2:
> - add commit message on each patch
> - add Jamie's and Christophe's Reviewed-by tag
> 
> Tudor Ambarus (9):
>   crypto: authenc - don't leak pointers to authenc keys
>   crypto: authencesn - don't leak pointers to authenc keys
>   crypto: caam - don't leak pointers to authenc keys
>   crypto: caam/qi - don't leak pointers to authenc keys
>   crypto: chcr - don't leak pointers to authenc keys
>   crypto: ixp4xx - don't leak pointers to authenc keys
>   crypto: picoxcell - don't leak pointers to authenc keys
>   crypto: qat - don't leak pointers to authenc keys
>   crypto: talitos - don't leak pointers to authenc keys
> 
>  crypto/authenc.c                         | 11 +++++------
>  crypto/authencesn.c                      | 11 +++++------
>  drivers/crypto/caam/caamalg.c            |  2 ++
>  drivers/crypto/caam/caamalg_qi.c         |  2 ++
>  drivers/crypto/chelsio/chcr_algo.c       |  5 +++++
>  drivers/crypto/ixp4xx_crypto.c           |  2 ++
>  drivers/crypto/picoxcell_crypto.c        |  2 ++
>  drivers/crypto/qat/qat_common/qat_algs.c |  3 +++
>  drivers/crypto/talitos.c                 |  2 ++
>  9 files changed, 28 insertions(+), 12 deletions(-)

Patches 3-9 applied.  Please remove the unrelated changes from
patches 1-2 and resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux