On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote: > > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote: > > This patch fixes the clang warning of extraneous parentheses, with the > > following coccinelle script. > > > > @@ > > identifier i; > > constant c; > > @@ > > ( > > -((i == c)) > > +i == c > > > > > > > -((i <= c)) > > +i <= c > > Why just the "==" and "<=" cases? > Why not "<", ">" and ">=" too? > > Why not expression instead of constant? Initially I had the other cases too and used expression instead of constant. But the results included only "==" and "<=" cases with constant. Along with one false positive case. --- a/drivers/crypto/cavium/zip/zip_main.c +++ b/drivers/crypto/cavium/zip/zip_main.c @@ -99,7 +99,7 @@ static struct zip_device *zip_alloc_devi */ struct zip_device *zip_get_device(int node) { - if ((node < MAX_ZIP_DEVICES) && (node >= 0)) + if (node < MAX_ZIP_DEVICES && node >= 0) return zip_dev[node]; zip_err("ZIP device not found for node id %d\n", node); I checked if there was any case of extra parentheses around relational operators left, but there were none. Hence, in the script I included only the cases present in the result. Thanks, Varsha