On Fri, Mar 16, 2018 at 8:56 AM, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Mar 08, 2018 at 01:57:02PM -0800, Kees Cook wrote: >> On the quest to remove all VLAs from the kernel[1], this switches to >> a pair of kmalloc regions instead of using the stack. This also moves >> the get_random_bytes() after all allocations (and drops the needless >> "nbytes" variable). >> >> [1] https://lkml.org/lkml/2018/3/7/621 >> >> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx> > > Patch applied. Thanks. Hi, sorry for the noise on this one: I messed up looking at the ecc code (I confused myself into thinking there was only a single instance of the problem). The applied patch is both incomplete and inefficient. I have a much simpler solution, and I'll send that with a revert... -Kees -- Kees Cook Pixel Security
