On Thu, Mar 15, 2018 at 03:49:33PM +0100, Arnd Bergmann wrote:
> On Thu, Mar 15, 2018 at 11:50 AM, Aaron Wu <aaron.wu@xxxxxxxxxx> wrote:
> > Signed-off-by: Aaron Wu <aaron.wu@xxxxxxxxxx>
> >
> > Remove Blackfin crypto support
> > ---
> > crypto/testmgr.c | 6 -
> > crypto/testmgr.h | 88 ------
>
> I'm not sure about this one: while the function name indicates that this is
> blackfin specific, my reading of the code is that it would also apply to
> any other crc32 accelerator like drivers/crypto/stm32/stm32_crc32.c
>
> Should I include this removal in my series or not?
Please send all these bfin_crc patches through the crypto tree.
> > diff --git a/crypto/testmgr.c b/crypto/testmgr.c
> > index d5e23a1..8dacd69 100644
> > --- a/crypto/testmgr.c
> > +++ b/crypto/testmgr.c
> > @@ -3070,12 +3070,6 @@ static const struct alg_test_desc alg_test_descs[] = {
> > .hash = __VECS(ghash_tv_template)
> > }
> > }, {
> > - .alg = "hmac(crc32)",
> > - .test = alg_test_hash,
> > - .suite = {
> > - .hash = __VECS(bfin_crc_tv_template)
> > - }
> > - }, {
Yes this should be removed. While we do still have other crc32
implementations and you could apply the hmac template on them,
it makes no sense to do so and nobody provides a direct hmac(crc32)
implementation.
So there is no point for this test vector to exist.
Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
