On 3/7/2018 6:29 PM, Sabrina Dubroca wrote:
> 2018-03-06, 21:09:25 +0530, Atul Gupta wrote:
>> Read FW capability. Read key area size. Dump the TLS record count.
> That's not a really helpful commit message. Have a look at other
> commit messages and try to be more descriptive.
> It's also not clear if those changes belong together in one patch, but
> I can't judge because the commit message is really too terse.
will add the description
>
>> Signed-off-by: Atul Gupta <atul.gupta@xxxxxxxxxxx>
>> ---
>> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 32 +++++---
>> drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 7 ++
>> drivers/net/ethernet/chelsio/cxgb4/sge.c | 98 ++++++++++++++++++++++++-
>> 3 files changed, 126 insertions(+), 11 deletions(-)
> [snip]
>> +int cxgb4_immdata_send(struct net_device *dev, unsigned int idx,
>> + const void *src, unsigned int len)
>> +{
>> + struct adapter *adap = netdev2adap(dev);
>> + struct sge_uld_txq_info *txq_info;
>> + struct sge_uld_txq *txq;
>> + int ret;
>> +
>> + local_bh_disable();
>> + txq_info = adap->sge.uld_txq_info[CXGB4_TX_OFLD];
>> + if (unlikely(!txq_info)) {
>> + WARN_ON(true);
>> + return NET_XMIT_DROP;
> Don't you need to local_bh_enable() before returning? If not, this
> needs a comment to explain why.
should enable before return [thanks]
>
>> + }
>> + txq = &txq_info->uldtxq[idx];
>> +
>> + ret = ofld_xmit_direct(txq, src, len);
>> + local_bh_enable();
>> + return net_xmit_eval(ret);
>> +}
>> +EXPORT_SYMBOL(cxgb4_immdata_send);
