On Wed, Mar 7, 2018 at 8:54 AM, PrasannaKumar Muralidharan <prasannatsmkumar@xxxxxxxxx> wrote: > Hi Rob, > > On 6 March 2018 at 19:25, Rob Herring <robh+dt@xxxxxxxxxx> wrote: >> On Tue, Mar 6, 2018 at 3:32 AM, James Hogan <jhogan@xxxxxxxxxx> wrote: >>> On Mon, Sep 18, 2017 at 07:32:40PM +0530, PrasannaKumar Muralidharan wrote: >>>> Add RNG node to jz4780 dtsi. This driver uses registers that are part of >>>> the register set used by Ingenic CGU driver. Use regmap in RNG driver to >>>> access its register. Create 'simple-bus' node, make CGU and RNG node as >>>> child of it so that both the nodes are visible without changing CGU >>>> driver code. >> >> The goal should be to avoid changing the DT (because the h/w hasn't >> changed), not avoid changing a driver. > > Please have a look at the discussion happened at > https://patchwork.linux-mips.org/patch/14094/. Looks like there is a > difference in though process between you and mips folks. I am not an > expert in DT so please suggest me the correct way to go about this. Those comments are correct too. Simply, there is no reason you have to add a rng node to add an RNG driver. The driver that probes the existing node can register both clocks and as an RNG provider. Rob
