Hi Fabio, On 03/06/2018 12:24 AM, Fabio Estevam wrote: > Hi Vladimir, > > On Mon, Mar 5, 2018 at 7:21 PM, Vladimir Zapolskiy <vz@xxxxxxxxx> wrote: >> The driver works well on i.MX31 powered boards with device description >> taken from board device tree, the only change to add to the driver is >> the missing OF device id, the affected list of included headers and >> indentation in platform driver struct are beautified a little. > > Patch looks good. > you are welcome to ack :) > I have an off-topic question though :-) > > Do you have mx31 device tree related patches so that you can test this? Yes, I have a pretty good i.MX31 dtsi change (tested everything but USB and multimedia, and that notorious watchdog problem still has to be agreed with Uwe and solved), but I'm trying to save my time a little, and my plan is to send everything altogether as a single imx31.dtsi update (without instant pinctrl though). And basically RNGA support is the only missing part at the moment. > Do we have mx31 pinctrl support? Yes, I have a complete and well tested i.MX31 pinctrl driver, it is done similarly to all known Freescale pin controller drivers. I sort of dislike it, and my preference is to "upgrade" it to utilize generic pin multiplexing with groups, functions and pin configuration as it is described in pinctrl-bindings.txt, then hopefully some ideas or code can be migrated to support modern Freescale/NXP SoCs. Legacy i.MX31 could serve as a distant and convenient test site in my opinion. > Please advise. > -- With best wishes, Vladimir
