From: Eric Biggers <ebiggers@xxxxxxxxxx> The PKCS#7 parser is guaranteed to set ->sig->hash_algo for every SignerInfo, since pkcs7_sig_note_digest_algo() is a mandatory action in the PKCS#7 ASN.1 grammar, and it returns an error code if an unrecognized DigestAlgorithmIdentifier is given rather than leaving the algorithm as NULL. Therefore, remove the unnecessary NULL check. Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> --- crypto/asymmetric_keys/pkcs7_verify.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/crypto/asymmetric_keys/pkcs7_verify.c b/crypto/asymmetric_keys/pkcs7_verify.c index 97c77f66b20d..a9e03f5c52e7 100644 --- a/crypto/asymmetric_keys/pkcs7_verify.c +++ b/crypto/asymmetric_keys/pkcs7_verify.c @@ -33,9 +33,6 @@ static int pkcs7_digest(struct pkcs7_message *pkcs7, kenter(",%u,%s", sinfo->index, sinfo->sig->hash_algo); - if (!sinfo->sig->hash_algo) - return -ENOPKG; - /* Allocate the hashing algorithm we're going to need and find out how * big the hash operational data will be. */ -- 2.16.0.rc1.238.g530d649a79-goog