On Fri, Jan 26, 2018 at 11:43:28PM +0800, Herbert Xu wrote: > On Thu, Jan 18, 2018 at 09:58:13AM +0100, LABBE Corentin wrote: > > > > I have two way of adding a new netlink request > > - keep the current patch and simply add a new CRYPTO_MSG_GETSTAT which use the same function than CRYPTO_MSG_GETALG > > => minimal changes, in fact CRYPTO_MSG_GETSTAT and CRYPTO_MSG_GETALG would be the same, but it is easy for userspace to test presence of stat. > > - Create a new CRYPTO_MSG_GETSTAT which imply lot of code and add a new crypto_user_stat.c > > => this imply also to change makefile (rename crypto_user.c to crypto_user_base.c) since crypto_user.ko is made of two files. > > > > Which one do you prefer ? > > I think you should check with the crconf author, Steffen Klassert > since that will be affected by this change. I still haven't had time to look into the details, but I'm fine with everything that does not break existing userspace. Everything else would be a 'no go'.
