Am Dienstag, 30. Januar 2018, 16:08:57 CET schrieb Benjamin Warnke: Hi Benjamin, Please run checkpatch.pl on the patch and fix the formatting issues. In general: I do not think that having larger C functions in header files is a proper coding style. Also, having static variables header files is also not nice. Do not redefine code that already exists. For example, MIN/MAX exists: min_t and max_t. Why are there __attribute__ ((unused)) function parameters, such as in compress_bitshuffle and others? Ciao Stephan
