Re: Getting the ccree driver out of staging

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

Here are my remaining Smatch warnings:

    drivers/staging/ccree/cc_driver.c:219 init_cc_resources()
    error: '%pa' can only be followed by one of [dp]

drivers/staging/ccree/cc_driver.c
   217  
   218          if (rc) {
   219                  dev_err(dev, "Failed in dma_set_mask, mask=%par\n",
                                                                      ^
This 'r' is is treated as a 'p'.  Not sure what was intended.

   220                          &dma_mask);
   221                  return rc;
   222          }
   223  


    drivers/staging/ccree/cc_buffer_mgr.c:1067 cc_aead_chain_data()
    warn: inconsistent indenting

drivers/staging/ccree/cc_buffer_mgr.c
  1064          if (src_mapped_nents > LLI_MAX_NUM_OF_DATA_ENTRIES) {
  1065                  dev_err(dev, "Too many fragments. current %d max %d\n",
  1066                          src_mapped_nents, LLI_MAX_NUM_OF_DATA_ENTRIES);
  1067                          return -ENOMEM;
                                ^^^^^^^^^^^^^^
  1068          }

    drivers/staging/ccree/cc_cipher.c:373 cc_cipher_setkey()
    warn: inconsistent indenting

drivers/staging/ccree/cc_cipher.c
   369          dma_sync_single_for_device(dev, ctx_p->user.key_dma_addr,
   370                                     max_key_buf_size, DMA_TO_DEVICE);
   371          ctx_p->keylen = keylen;
   372  
   373           dev_dbg(dev, "return safely");
                ^
One extra space.

   374          return 0;
   375  }

regards,
dan carpenter