On 9 January 2018 at 11:47, Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote: > On 9 January 2018 at 08:31, Riku Voipio <riku.voipio@xxxxxxxxxx> wrote: >> Hi, >> >> Loading omap_rng module on McBin causes hangup (in about 9/10 times). >> Looking at /proc/interrupts it seems the interrupt starts running like >> crazy, and after a while the whole system is unresponsive. This with >> Debian kernel (everything possible as modules) and EFI as bootloader. >> The EFI firmware appears[1] to use the rng unit to provide a seed for >> KASRL, I wonder if the driver needs to depend less on the state left >> by firmware, or the firmware needs to de-initialize the RNG before >> booting. >> > ... >> 87: 0 0 0 0 ICU.f21e0000 95 >> Level f2760000.trng >> 88: 2532580 0 0 0 ICU.f41e0000 95 >> Level f4760000.trng > ... > > My original code had > > gMarvellTokenSpaceGuid.PcdEip76TrngBaseAddress|0xF2760000 > > which means the interrupt storm is being caused by the /other/ RNG, > not the one UEFI uses. > > Could you please check whether your UEFI source is still using the > same base address? Good catch. Looks like it is: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/blob/marvell-armada-wip-variables/Platforms/Marvell/Armada/Armada.dsc.inc#L374 Riku