Re: [v1] crypto: crypto4xx - perform aead icv check in the driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 23, 2017 at 07:45:46PM +0100, Christian Lamparter wrote:
> The ccm-aes-ppc4xx now fails one of testmgr's expected
> failure test cases as such:
> 
> |decryption failed on test 10 for ccm-aes-ppc4xx:
> |ret was 0, |expected -EBADMSG
> 
> It doesn't look like the hardware sets the authentication failure
> flag. The original vendor source from which this was ported does
> not have any special code or notes about why this would happen or
> if there are any WAs.
> 
> Hence, this patch converts the aead_done callback handler to
> perform the icv check in the driver. And this fixes the false
> negative and the ccm-aes-ppc4xx passes the selftests once again.
> 
> |name         : ccm(aes)
> |driver       : ccm-aes-ppc4xx
> |module       : crypto4xx
> |priority     : 300
> |refcnt       : 1
> |selftest     : passed
> |internal     : no
> |type         : aead
> |async        : yes
> |blocksize    : 1
> |ivsize       : 16
> |maxauthsize  : 16
> |geniv        : <none>
> 
> Signed-off-by: Christian Lamparter <chunkeey@xxxxxxxxx>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux