On Thu, Dec 7, 2017 at 9:21 PM, Brijesh Singh <brijesh.singh@xxxxxxx> wrote: > > > On 12/06/2017 03:10 PM, Philippe Ombredanne wrote:>> diff --git > a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c >>> >>> new file mode 100644 >>> index 000000000000..b5789f878560 >>> --- /dev/null >>> +++ b/drivers/crypto/ccp/psp-dev.c >>> @@ -0,0 +1,105 @@ >>> +/* >>> + * AMD Platform Security Processor (PSP) interface >>> + * >>> + * Copyright (C) 2016-2017 Advanced Micro Devices, Inc. >>> + * >>> + * Author: Brijesh Singh <brijesh.singh@xxxxxxx> >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License version 2 as >>> + * published by the Free Software Foundation. >>> + */ >> >> >> Dear Brijesh, >> >> Have you considered using the new SPDX license ids instead? >> >> This would come out this way: >>> >>> +// SDPX-License-Identifier: GPL-2.0 >>> +/* >>> + * AMD Platform Security Processor (PSP) interface >>> + * >>> + * Copyright (C) 2016-2017 Advanced Micro Devices, Inc. >>> + * >>> + * Author: Brijesh Singh <brijesh.singh@xxxxxxx> >>> + */ >> >> >> It is much cleaner and simpler, right? >> >> For the C++ comment style and first line placement, please see Thomas >> (tlgx) doc patches and Linus posts explaining his rationale of why he >> wants it this way. >> It would be awesome if this could be applied to all AMD contributions btw! >> > > Hi Philippe, > > I was not aware of SPDX identifier, If v10 is needed for SEV series then I > will certainly update the patches to use SPDX license identifier. thanks Brijesh, that's very kind of you! -- Cordially Philippe Ombredanne