Am Donnerstag, 7. Dezember 2017, 16:08:04 CET schrieb Atul Gupta: Hi Atul, > > As far as I see, the key is part of the skb (via kctx). This skb is > > released after being processed. The release calls kfree_skb which does > > not zeroize the key. Wouldn't it make sense to clear the memory of the > > key when the skb is released? [Atul] we should perhaps memset the info > > received from user so that driver has no info on key once its written on > > chip memory. memset(gcm_ctx->key, 0, keylen); > > Are you saying that the skb (via kctx) above does not obtain a copy of the > key? If not, what is done in chtls_key_info? It does have a key copy, I was > not sure how key info is accessed once skb is released. All I am saying is that this key copy should be zapped when the memory is released. Thus, if the skb has a copy of the key, at least at the time of free() of the skb, a memset() of the key memory should be done (or before). > > > Ciao > Stephan > > Thanks > Atul Ciao Stephan
