On Mon, Dec 4, 2017 at 11:36 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Sun, Dec 03, 2017 at 01:58:12PM +0000, Gilad Ben-Yossef wrote: >> The ccree drivers was marking a lot of big functions in C file as >> static inline for no good reason. Remove the inline qualifier from >> any but the few truly single line functions. >> > > The compiler is free to ignore inline hints... It probably would make > single line functions inline anyway. > Yes. I think of it more as a note to the reader: "don't add stuff to this function. it is meant to be short and simple". -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru