This is another batch of ccree fixes & cleanups. The first patch is a bug fix. All others are pure readability and coding style fixes. Changes from v1: - Fix several coding style issues pointed out by Dan Carpenter. - Added two more patches of similar issues that surfaced during the review. Gilad Ben-Yossef (10): staging: ccree: fix leak of import() after init() staging: ccree: make long func call sites readable staging: ccree: simplify AEAD using local var staging: ccree: simplify buf mgr using local vars staging: ccree: fold common code into function staging: ccree: simplify pm manager using local var staging: ccree: remove unneeded cast staging: ccree: remove compare to none zero staging: ccree: remove braces for single statement staging: ccree: remove unused cc_base parameter drivers/staging/ccree/ssi_aead.c | 60 ++-- drivers/staging/ccree/ssi_buffer_mgr.c | 553 ++++++++++++++------------------ drivers/staging/ccree/ssi_buffer_mgr.h | 49 ++- drivers/staging/ccree/ssi_cipher.c | 39 ++- drivers/staging/ccree/ssi_driver.c | 51 ++- drivers/staging/ccree/ssi_driver.h | 2 +- drivers/staging/ccree/ssi_hash.c | 201 ++++++------ drivers/staging/ccree/ssi_ivgen.c | 4 +- drivers/staging/ccree/ssi_pm.c | 46 ++- drivers/staging/ccree/ssi_pm.h | 12 +- drivers/staging/ccree/ssi_request_mgr.c | 29 +- drivers/staging/ccree/ssi_request_mgr.h | 6 +- drivers/staging/ccree/ssi_sram_mgr.c | 13 +- drivers/staging/ccree/ssi_sram_mgr.h | 6 +- 14 files changed, 502 insertions(+), 569 deletions(-) -- 2.7.4