Hi Jim, Have second thoughts on this. On 3 November 2017 at 20:55, PrasannaKumar Muralidharan <prasannatsmkumar@xxxxxxxxx> wrote: >> >> It would be cleaner to just get rid of probe_common() altogether in that >> case, and do whatever >> needs to be done in virtrng_probe()/virtrng_restore() respectively, but > > That's correct. > >> I didn't want to change code >> affecting the normal probe path as well as suspend/resume. Is it OK to >> leave it that way to avoid >> the more extensive changes ? > > Personally I would prefer to do the cleaner way. It is up to the > virtio and hwrng maintainer. You are trying to restore the status quo of the driver that was before the commit 5c06273401. It is really important and valid. The driver's suspend/resume code is not in best shape but that is not what you are trying to solve. I am fine with this change. Regards, PrasannaKumar
