Re: [PATCH 2/4] crypto: dh - don't permit 'p' to be 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 2/4] crypto: dh - don't permit 'p' to be 0
From: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
Date: Thu, 2 Nov 2017 13:40:51 +0200
Cc: <keyrings@xxxxxxxxxxxxxxx>, Mat Martineau <mathew.j.martineau@xxxxxxxxxxxxxxx>, Salvatore Benedetto <salvatore.benedetto@xxxxxxxxx>, Stephan Mueller <smueller@xxxxxxxxxx>, Eric Biggers <ebiggers@xxxxxxxxxx>, <stable@xxxxxxxxxxxxxxx>
In-reply-to: <20171101222517.41602-3-ebiggers3@gmail.com>
References: <20171101222517.41602-1-ebiggers3@gmail.com> <20171101222517.41602-3-ebiggers3@gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

Hi, Eric,

On 11/02/2017 12:25 AM, Eric Biggers wrote:

If 'p' is 0 for the software Diffie-Hellman implementation, then
dh_max_size() returns 0.


dh_set_secret() returns -EINVAL if p_len < 1536, see
dh_check_params_length(). What am I missing?

Cheers,
ta

Follow-Ups:
- Re: [PATCH 2/4] crypto: dh - don't permit 'p' to be 0
  - From: Eric Biggers

References:
- [PATCH 0/4] crypto: dh - input validation fixes
  - From: Eric Biggers
- [PATCH 2/4] crypto: dh - don't permit 'p' to be 0
  - From: Eric Biggers

Prev by Date: Re: [PATCH 1/4] crypto: dh - fix double free of ctx->p
Next by Date: Re: [PATCH] crypto: ccm - preserve the IV buffer
Previous by thread: [PATCH 2/4] crypto: dh - don't permit 'p' to be 0
Next by thread: Re: [PATCH 2/4] crypto: dh - don't permit 'p' to be 0
Index(es):
- Date
- Thread

[Index of Archives] [Kernel] [Gnu Classpath] [Gnu Crypto] [DM Crypt] [Netfilter] [Bugtraq]

Powered by Linux