On Sun, Oct 15, 2017 at 6:38 PM, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Sun, Oct 15, 2017 at 10:19:45AM +0100, Gilad Ben-Yossef wrote: > > > > Changes from v8: > > - Remove the translation of EAGAIN return code to the > > previous return code of EBUSY for the user space > > interface of algif as no one seems to rely on it as > > requested by Herbert Xu. > > Sorry, but I forgot to mention that EAGAIN is not a good value > to use because it's used by the network system calls for other > meanings (interrupted by a signal). > > So if we stop doing the translation then we also need to pick > a different value, perhaps E2BIG or something similar that have > no current use within the crypto API or network API. Yes, I see what you mean. With a netlink based interface this can be confusing to debug. Would you mind if we used ENOSPC instead of E2BIG? "No space left on device" seems more appropriate than "Argument list too long". Thanks, Gilad -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru
