Hello Vladimir, >>[snip] >> -static struct s5p_aes_dev *s5p_dev; >> +enum hash_op { >> + HASH_OP_UPDATE = 1, >> + HASH_OP_FINAL = 2 >> +}; > > If this type is not going to be extended, then I'd rather suggest to > use a boolean correspondent field in the struct s5p_hash_reqctx instead > of a new introduced type. [...] In prevoious mail I wrote 'op_final', but this will actually be 'op_update'. -- Best regards, Kamil Konieczny Samsung R&D Institute Poland