On Thu, Oct 12, 2017 at 03:11:07PM -0500, Brijesh Singh wrote: > Lets consider this scenario > 1- platform is in uninit state, we transition it to INIT > 2- PEK_GEN command failed > 3- since we have transitioned the platform in INIT state hence we must > call the shutdown otherwise we will leave the system in wrong state. The > shutdown command will most probably succeed and we will look the ret value Sure but what do you do if the main command, i.e., PEK_GEN succeeds but the shutdown command fails? You probably should carve out the whole shutdown order in separate functions. I mean, the sequences do repeat in a couple of functions so you could do: ioctl: case <CMD>: init_platform() do_main_cmd() shutdown_platform() break; and this way you have everything nicely separated and retvals properly tracked... Hmmm? -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --