Hi, David, On 10/03/2017 12:06 PM, David Howells wrote:
Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx> wrote:-static inline int dh_data_size(const struct dh *p) +static inline unsigned int dh_data_size(const struct dh *p) { return p->key_size + p->p_size + p->g_size; }If this is a problem, do you need to do range checking?
The algorithm does not impose any constraint in this direction, as far as I'm aware of. It's unnatural to return a signed integer in a function which just sums unsigned integers. No checking is needed, the function should return the unsigned result. Cheers, ta
