2017-09-24 11:05 GMT-04:00 Johannes Berg <johannes@xxxxxxxxxxxxxxxx>: > On Sun, 2017-09-24 at 01:40 -0400, Xiang Gao wrote: >> Currently, the aes_ccm.c and aes_gcm.c are almost line by line >> copy of each other. This patch reduce code redundancy by moving >> the code in these two files to crypto/aead_api.c to make it a >> higher level aead api. The aes_ccm.c and aes_gcm.c are removed >> and all the functions are now implemented in their headers using >> the newly added aead api. >> > No objection from me, though I'd ask you to respin with the indentation > fixed up a bit. Hi Johannes, Thank you for you time for the suggestion. I'm not sure if I correctly understand you point. Do you mean to put more characters each line in the description? Something like: > Currently, the aes_ccm.c and aes_gcm.c are almost line by line copy of > each other. This patch reduce code redundancy by moving the code in these > two files to crypto/aead_api.c to make it a higher level aead api. The > file aes_ccm.c and aes_gcm.c are removed and all the functions there are > now implemented in their headers using the newly added aead api. instead of > Currently, the aes_ccm.c and aes_gcm.c are almost line by line > copy of each other. This patch reduce code redundancy by moving > the code in these two files to crypto/aead_api.c to make it a > higher level aead api. The aes_ccm.c and aes_gcm.c are removed > and all the functions are now implemented in their headers using > the newly added aead api. Xiang Gao > > johannes
