On Thu, Sep 07, 2017 at 06:15:55PM -0500, Gary R Hook wrote: > I would prefer that we not shorten this. The prior incarnation, > ccp_alloc_struct(), has/had been around for a while. And there are a > number of similarly named allocation functions in the driver that we > like to keep sorted. If anything, it should be more explanatory, IMO. Well, looks like an AMD practice: $ git grep --name-only alloc_struct drivers/crypto/ccp/ccp-dev.c drivers/crypto/ccp/ccp-dev.h drivers/crypto/ccp/psp-dev.c drivers/crypto/ccp/sev-dev.c drivers/crypto/ccp/sp-dev.c drivers/crypto/ccp/sp-dev.h drivers/crypto/ccp/sp-pci.c drivers/crypto/ccp/sp-platform.c drivers/gpu/drm/amd/amdkfd/kfd_dbgmgr.c drivers/gpu/drm/amd/amdkfd/kfd_priv.h drivers/gpu/drm/amd/amdkfd/kfd_topology.c But whatever, if you like it more that way... :) -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --