On Thu, 2017-09-07 at 00:32 +0300, Dan Carpenter wrote: > Always compile your patches. > > CC [M] drivers/staging/ccree/ssi_cipher.o > drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’: > drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable ‘inflight_counter’ [-Wunused-variable] > u32 inflight_counter; > ^~~~~~~~~~~~~~~~ > > You need to delete the declaration as well. > > Don't be in a rush to resend patches. I normally write them then let > them sit in my outbox overnight and send them in the morning. The extra > delay helps me to calm down a bit and focus better. Even though I've > sent thousands of patches, it sometimes still stresses me out. It's > like you're disagreeing with the original author and the reviewers are > disagreeing with you and everyone's trying to be nice about it but > patches are fundamentally points of disagreement and that's stress. True, and you shouldn't add a blank link either. there's already one above the block you deleted.
