Re: [PATCH] crypto: MPI - kunmap after finishing accessing buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 30, 2017 at 06:33:41PM +0200, Stephan Mueller wrote:
> Am Dienstag, 22. August 2017, 08:33:15 CEST schrieb Herbert Xu:
> 
> Hi Herbert,
> 
> > On Thu, Aug 10, 2017 at 08:06:18AM +0200, Stephan Müller wrote:
> > > Hi Herbert,
> > > 
> > > I found that issue while playing around with edge conditions in my
> > > algif_akcipher implementation. This issue only manifests in a
> > > segmentation violation on 32 bit machines and with an SGL where each
> > > SG points to one byte. SGLs with larger buffers seem to be not
> > > affected by this issue.
> > > 
> > > Yet this access-after-unmap should be a candidate for stable, IMHO.
> > 
> > Good catch.  Thanks!
> > 
> > Fixes: 4816c9406430 ("lib/mpi: Fix SG miter leak")
> > Cc: <stable@xxxxxxxxxxxxxxx>
> 
> Just to confirm: stable is not CCed in this email -- did you send it 
> separately to stable? (dto for "[PATCH v4] crypto: only call put_page on 
> referenced and used pages")

The cc is meant to go into the commit and when the commit hits
mainline it'll automatically get picked up by stable.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux